Only create layer env directories if env vars are being written
#385
Conversation
Prevents empty `env`, `env.build` and `env.launch` directories from being created within each layer's directory, if no environment variables are set within them. Fixes #384. GUS-W-10905886.
|
There wasn't an obvious existing test to adapt or duplicate - I'll let you decide whether we need a new test for this or not :-) |
There was a problem hiding this comment.
Thanks for the fix! 👍🏻
I was thinking about recommending to move the fs::create_dir_all into the for to avoid the extra check for emptiness, but in the end it does not really matter and might even have slightly worse runtime characteristics.
If anything, the comment threw me off at first since it (for me at least) comments the whole block, not only the if. But we can keep it there. :)
I would think it would be definitely worse (albeit still not enough to be measurable) - one in-memory |
Prevents empty
env,env.buildandenv.launchdirectories from being created within each layer's directory, if no environment variables are set within them.Fixes #384.
GUS-W-10905886.